Add integration test for procspy edges. #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
779-procspy-integration-test
branch
2 times, most recently
from
205f951 to
e5b8e0c
Compare
tomwilkie
changed the title
| @@ -44,58 +36,84 @@ scope_end_suite() { | |||
| done | |||
| } | |||
|
|
|||
| # this checks we have a named node in the given view | |||
| has() { | |||
| local view=$1 | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
779-procspy-integration-test
branch
from
e5b8e0c to
fe95714
Compare
|
@paulbellamy PTAL |
|
Ok, so the salient point of these tests is that when conntrack is off the probe is forced to use procspy, correct? if so, let's either mention procspy in the test name, or a comment on why conntrack is disabled. |
tomwilkie
force-pushed
the
779-procspy-integration-test
branch
from
fe95714 to
57a06cb
Compare
|
@paulbellamy kinda - we're checking process to process edges, which only come from procspy. Have added this to test name. |
paulbellamy
added a commit
that referenced
this pull request
Jan 6, 2016
Add integration test for procspy edges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779