Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Applications -> Process, sort topologies by rank. #866

Merged
merged 3 commits into from
Feb 2, 2016

Conversation

tomwilkie
Copy link
Contributor

Fixes #852

@paulbellamy
Copy link
Contributor

$ ag -i application | grep -v vendor
...
experimental/_integration/easy_test.go:29:func TestApplications(t *testing.T) {
experimental/_integration/easy_test.go:31:      topo := parseTopology(t, httpGet(t, fmt.Sprintf("http://localhost:%d/api/topology/applications", appPort)))
experimental/_integration/easy_test.go:34:      have := parseEdge(t, httpGet(t, fmt.Sprintf("http://localhost:%d/api/topology/applications/%s/%s", appPort, "proc:node-192.168.1.1:wget", "theinternet")))
experimental/_integration/easy_test.go:59:      topo := parseTopology(t, httpGet(t, fmt.Sprintf("http://localhost:%d/api/topology/applications", appPort)))
experimental/graphviz/render.go:12:     "applications":         render.FilterUnconnected(render.ProcessWithContainerNameRenderer),
experimental/graphviz/render.go:13:     "applications-by-name": render.FilterUnconnected(render.ProcessNameRenderer),
...
render/detailed/node.go:98:     {report.Process, NodeSummaryGroup{TopologyID: "applications", Label: "Applications", Columns: []string{process.PID, process.CPUUsage, process.MemoryUsage}}},
render/detailed/node_test.go:104:               Label:      "Applications",
render/detailed/node_test.go:105:               TopologyID: "applications",
render/detailed/node_test.go:159:               Label:      "Applications",
render/detailed/node_test.go:160:               TopologyID: "applications",
...

@tomwilkie
Copy link
Contributor Author

@paulbellamy PTAL

paulbellamy added a commit that referenced this pull request Feb 2, 2016
Rename Applications -> Process, sort topologies by rank.
@paulbellamy paulbellamy merged commit 1e4b872 into master Feb 2, 2016
@paulbellamy paulbellamy deleted the 852-processes branch February 2, 2016 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants