Show nice column labels when no children have metrics #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
939-no-column-labels-when-no-metrics
branch
from
8e81603 to
89d7ebe
Compare
|
Code looks good! Awesome seeing that big chuck get deleted. Tricky to repro tho, how does one get a host w/ no containers running? Won't the probe be running in a container to see that host? Or the probe is running straight on the host, and docker is also running on the host, w/ other containers stopped. |
|
So this was showing in containers-by-image, where all containers were stopped. |
|
Got it! Thanks! |
|
LGTM |
paulbellamy
added a commit
that referenced
this pull request
Feb 10, 2016
…metrics Show nice column labels when no children have metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939
"columns":["a", "b"]becomes"columns":[{"id":"a", "label":"A"}, {"id":"b", "label":"B"}]