WIP: Integration test build improvements #2149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules are all in the 'else' side of $(BUILD_IN_CONTAINER)
So we don't need to build the build container in the integration test step at CircleCI. Also, consistency.
bboreham
force-pushed
the
integration-test-tasks
branch
2 times, most recently
from
ccfb62d to
1bba580
Compare
bboreham
force-pushed
the
integration-test-tasks
branch
from
1bba580 to
5af7aea
Compare
bboreham
force-pushed
the
integration-test-tasks
branch
from
e1fd320 to
a7490c2
Compare
bboreham
force-pushed
the
integration-test-tasks
branch
from
a7490c2 to
6118bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was begun in an attempt to fix #2147.
Filing so others can see what I was doing; it doesn't meet goals yet.