This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
offsetguess: fix rare failures on offset guessing #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases Go didn't have enough time to actually do a connection and the 1 ms timeout was triggered leaving the guess offset state machine in an invalid state. Give a bit more time to do the connection.
Some IPv6 addresses (multicast and link-local) don't result in struct sock having the address in the correct field, defeating the purpose of the guessing offsets code. Don't generate multicast or link-local addresses.
alban
approved these changes
Mar 8, 2017
|
After 5000 runs of the guessing offset code I got no errors. Before this PR, I got around 10-15 errors every 1000 runs. |
2 tasks
sunhay
pushed a commit
to DataDog/tcptracer-bpf
that referenced
this pull request
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetguess: add a longer timeout for tcp6 Dial
In rare cases Go didn't have enough time to actually do a connection
and the 1 ms timeout was triggered leaving the guess offset state
machine in an invalid state.
Give a bit more time to do the connection.
offsetguess: do not generate invalid IPv6 addresses
Some IPv6 addresses (multicast and link-local) don't result in struct
sock having the address in the correct field, defeating the purpose of
the guessing offsets code.
Don't generate multicast or link-local addresses.