Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add format for compact absolute timestamp #376

Merged
merged 1 commit into from
Sep 12, 2018
Merged

add format for compact absolute timestamp #376

merged 1 commit into from
Sep 12, 2018

Conversation

guyfedwards
Copy link
Contributor

@guyfedwards guyfedwards commented Sep 12, 2018 •
edited
Loading

If timestamp is absolute and compact, only show the date.

FOr new events UI design we show the date if more than 7days ago. We currently
don't use absolute timestamp anywhere so this is low impact.

image

@guyfedwards
add format for compact absolute timestamp
4cb5d0f 
If timestamp is absolute and compact, only show the date.
@guyfedwards guyfedwards requested a review from fbarl September 12, 2018 10:43
fbarl
fbarl approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, very nice!

@guyfedwards guyfedwards merged commit 6e59894 into master Sep 12, 2018
@guyfedwards guyfedwards deleted the timestamp-compact-absolute branch September 12, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyfedwards @fbarl