update jest, jest-styled-components, babel-jest #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jest@23.6.0 jest-styled-componetns@6.2.0 babel-jest@23.6.0 prerequisite for #372
Error message is much harded to track down when not using prop-types. We have linting to pick up on these and should rely on runtime errors.
foot
reviewed
Sep 17, 2018
src/components/Search/Search.js
Outdated
| @@ -221,7 +222,7 @@ Search.propTypes = { | |||
| * Handler that runs when an item from the search filter dropdown is selected | |||
| * Returns the selected filter value. | |||
| */ | |||
| onFilterSelect: PropTypes.func.isRequired, | |||
| onFilterSelect: requiredIf(PropTypes.func, props => props.filters), | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
onFilterSelect shouold only be required if props.filters is supplied adding react-required-if solves this.
guyfedwards
force-pushed
the
jest-update
branch
from
2658f54 to
136a6d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest@23.6.0
jest-styled-componetns@6.2.0
babel-jest@23.6.0
prerequisite for #372