Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Install Flux CLI prompt info message #27

Closed
2 tasks done
RandomFractals opened this issue Aug 29, 2021 · 5 comments
Closed
2 tasks done

Add Install Flux CLI prompt info message #27

RandomFractals opened this issue Aug 29, 2021 · 5 comments
Assignees
@usernamehw
Labels
feature New feature request UI UI issue or enhancement

Comments

@RandomFractals
Copy link
Collaborator

RandomFractals commented Aug 29, 2021 •
edited by usernamehw
Loading

with a link to flux CLI installation instructions: https://fluxcd.io/docs/installation/

As part of GitOps terminal initialization in #8, we should:

  • list flux version installed
  • display this prompt when flux check --pre command returns command not found error
@RandomFractals RandomFractals added the feature New feature request label Aug 29, 2021
@RandomFractals RandomFractals self-assigned this Aug 29, 2021
@RandomFractals RandomFractals mentioned this issue Sep 8, 2021
Closed
@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 27, 2021 •
edited
Loading

@usernamehw we can move this check to new gitops shell and output, and add a prompt if we get command not found error when trying flux check --pre.

@RandomFractals RandomFractals mentioned this issue Sep 27, 2021
Closed
@RandomFractals RandomFractals removed their assignment Sep 27, 2021
@RandomFractals RandomFractals added the UI UI issue or enhancement label Sep 27, 2021
usernamehw added a commit that referenced this issue Sep 28, 2021
@usernamehw
prompt to install kubectl and flux (#27, #29)
73b7ccd 
- Allow sending to output channel without revealing it
usernamehw added a commit that referenced this issue Sep 28, 2021
@usernamehw
do not send to output flux version (#27)
28c64f6
usernamehw added a commit that referenced this issue Sep 28, 2021
@usernamehw
use different button name for flux installation website (#27)
109c9cc
@usernamehw
Copy link
Collaborator

Notification is shown when flux is not installed:

Screenshot (263)

@RandomFractals
Copy link
Collaborator Author

RandomFractals commented Sep 28, 2021 •
edited
Loading

I think we should change that message to:

"Please install flux CLI to use GitOps Tools"

and change Installation page button label to Install Flux

@murillodigital & @josefaworks your take on it?

usernamehw added a commit that referenced this issue Sep 29, 2021
@usernamehw
change button name for flux install (#27)
85cdec6
@usernamehw
Copy link
Collaborator

Changed the button name:

Screenshot (268)

@RandomFractals
Copy link
Collaborator Author

I would prefer you used the message I suggested above.

Up to @josefaworks to review and come up with the final copy.

usernamehw added a commit that referenced this issue Sep 30, 2021
@usernamehw
fix notification message (#27)
f6e2a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usernamehw usernamehw

Labels
feature New feature request UI UI issue or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RandomFractals @usernamehw