Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create markdown table hovers for tree view items #57

Closed
4 of 18 tasks
usernamehw opened this issue Sep 10, 2021 · 6 comments
Closed
4 of 18 tasks

Create markdown table hovers for tree view items #57

usernamehw opened this issue Sep 10, 2021 · 6 comments
Assignees
Labels
feature New feature request

Comments

@usernamehw
Copy link
Collaborator

usernamehw commented Sep 10, 2021

Need to decide whish properties to show:

  • Api version
  • Kind
  • Name
  • Namespace
  • Cluster
    • ???
  • Git repository
    • ???
  • Helm repository
    • ???
  • Bucket
    • ???
  • Kustomize
    • ???
  • Helm release
    • ???
  • Flux controllers inside the cluster tree view
    • ???
@usernamehw usernamehw added the feature New feature request label Sep 10, 2021
@usernamehw usernamehw self-assigned this Sep 10, 2021
usernamehw added a commit that referenced this issue Sep 10, 2021
@usernamehw usernamehw mentioned this issue Sep 10, 2021
@RandomFractals
Copy link
Collaborator

@murillodigital Can you review the list above and our json output for all the loaded k8s objects in Clusters, Sources, and Deployments and let us know what other properties you want to include in those tree node tooltips?

RandomFractals pushed a commit that referenced this issue Sep 10, 2021
… nodes (#57) (#58)

- pass extension context to tree view data providers
- update `helmRelease.ts` flux interfaces (#49)
RandomFractals added a commit that referenced this issue Sep 10, 2021
…wn tooltips to the corresponding data providers and tree view item classes (#57 and #59)
@RandomFractals
Copy link
Collaborator

added tooltips for the different k8s object types we display in our tree views:

gitops-git-repo-info-tooltip

gitops-helm-repo-info-tooltip

gitops-bucket-info-tooltip

gitops-kustomization-info-tooltip

gitops-helm-release-info-tooltip

@murillodigital to add notes to this ticket if he wants to see those k8s object properties differently.

I did not include the cluster info tooltip because it has our sample cluster ip address. That one was shared in slack.

@RandomFractals
Copy link
Collaborator

this does look much better. I updated all of them to have table headers left aligned:

image

@RandomFractals
Copy link
Collaborator

@murillodigital just an fyi, we will be changing this to use generic markdown table string utility method that will show most of the k8s object properties without us handcoding that part. will be very similar to what you see in open configs from #60 now, except in a simple table format for quick overviews on hover.

@RandomFractals
Copy link
Collaborator

@usernamehw we should add top level properties display in a markdown table for the new flux system cluster deployment nodes you added in #36 when you get generic solution worked out.

@RandomFractals
Copy link
Collaborator

@murillodigital we did our best to pull the properties for the k8s object types and nodes we display in all of our custom gitops tree views.

I am going to close this ticket as finished.

You can open enhancement requests when you find the time to review them and find that those properties order, format, or lists should change.

See screenshots above, or install the latest version of this extension to preview them with your cluster configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants