fix: FakeClient expects finalizers to be set when DeletionTimestamp i…

…s set
weaveworks · Nov 6, 2023 · af57bbb · af57bbb
1 parent 8effc0f
commit af57bbb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/query/collector/reconciler/reconciler_test.go b/pkg/query/collector/reconciler/reconciler_test.go
@@ -120,14 +120,17 @@ func TestReconciler_Reconcile(t *testing.T) {
 	deletedHelmRelease := testutils.NewHelmRelease("deletedHelmRelease", clusterName, func(hr *v2beta1.HelmRelease) {
 		now := metav1.Now()
 		hr.DeletionTimestamp = &now
+		hr.Finalizers = append(hr.Finalizers, "finalizers.fluxcd.io")
 	})
 	deletedClusterRoleWithRules := testutils.NewClusterRole("deletedClusterRoleWithRules", true, func(cr *rbacv1.ClusterRole) {
 		now := metav1.Now()
 		cr.DeletionTimestamp = &now
+		cr.Finalizers = append(cr.Finalizers, "kubernetes")
 	})
 	deletedClusterRoleWithoutRules := testutils.NewClusterRole("deletedClusterRoleWithoutRules", false, func(cr *rbacv1.ClusterRole) {
 		now := metav1.Now()
 		cr.DeletionTimestamp = &now
+		cr.Finalizers = append(cr.Finalizers, "kubernetes")
 	})
 	deletedClusterRoleManuallyConstructed := testutils.NewClusterRole("deletedClusterRoleManuallyConstructed", false)
 	objects := []runtime.Object{createdOrUpdatedHelmRelease, deletedHelmRelease, deletedClusterRoleWithRules, deletedClusterRoleWithoutRules}