Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable license entitlement #3752

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mproffitt
Copy link

What changed?

Why was this change made?

As Weave GitOps Enterprise has now moved to OpenSource, the entitlement validation no longer makes sense as it relies on closed source code that probably won't remain in the codebase.

This change disables the check by removing irrelevant parts of code and setting the license expiry to always be time.Now() + 1 year

How was this change implemented?

How did you validate the change?

  • Explain how a reviewer can verify the change themselves

By deploying this branch on a license free cluster and verifying that the check no longer takes place

  • Integration tests -- what is covered, what cannot be covered;
    or, explain why there are no new tests

This removes functionality and does not introduce any new functionality that requires coverage

  • Unit tests -- what is covered, what cannot be covered; are
    there tests that fail without the change?

This removes tests that cover code that is no longer relevant

Release notes

This change removes the license entitlement verification

Documentation Changes

Other follow ups

@gecube
Copy link

gecube commented Feb 20, 2024

Looking forward when it would be merged and the gitops console utility and docker images for gitops platform would be rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants