helmrepository api version is v1beta2 not v1

weaveworks · Aug 22, 2023 · 9808968 · 9808968
1 parent e3b0570
commit 9808968
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/run/install/install_dashboard.go b/pkg/run/install/install_dashboard.go
@@ -4,12 +4,12 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	sourcev1b2 "github.com/fluxcd/source-controller/api/v1beta2"
 	"strings"
 	"time"
 
+	sourcev1b2 "github.com/fluxcd/source-controller/api/v1beta2"
+
 	helmv2 "github.com/fluxcd/helm-controller/api/v2beta1"
-	sourcev1 "github.com/fluxcd/source-controller/api/v1"
 	coretypes "github.com/weaveworks/weave-gitops/core/server/types"
 	"github.com/weaveworks/weave-gitops/pkg/config"
 	"github.com/weaveworks/weave-gitops/pkg/logger"
@@ -301,7 +301,7 @@ func makeHelmRepository(name, namespace string) *sourcev1b2.HelmRepository {
 	helmRepository := &sourcev1b2.HelmRepository{
 		TypeMeta: metav1.TypeMeta{
 			Kind:       sourcev1b2.HelmRepositoryKind,
-			APIVersion: sourcev1.GroupVersion.Identifier(),
+			APIVersion: sourcev1b2.GroupVersion.Identifier(),
 		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      name,

diff --git a/pkg/run/install/install_dashboard_test.go b/pkg/run/install/install_dashboard_test.go
@@ -8,7 +8,6 @@ import (
 	"time"
 
 	helmv2 "github.com/fluxcd/helm-controller/api/v2beta1"
-	sourcev1 "github.com/fluxcd/source-controller/api/v1"
 	sourcev1b2 "github.com/fluxcd/source-controller/api/v1beta2"
 	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo/v2"
@@ -397,7 +396,7 @@ var _ = Describe("makeHelmRepository", func() {
 	It("creates helmrepository", func() {
 		actual := makeHelmRepository(testDashboardName, testNamespace)
 		Expect(actual.Kind).To(Equal(sourcev1b2.HelmRepositoryKind))
-		Expect(actual.APIVersion).To(Equal(sourcev1.GroupVersion.Identifier()))
+		Expect(actual.APIVersion).To(Equal(sourcev1b2.GroupVersion.Identifier()))
 		Expect(actual.Name).To(Equal(testDashboardName))
 		Expect(actual.Namespace).To(Equal(testNamespace))