Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate Policies Icons #3782

Closed
joshri opened this issue Jun 12, 2023 · 7 comments · Fixed by #3846
Closed

Remove duplicate Policies Icons #3782

joshri opened this issue Jun 12, 2023 · 7 comments · Fixed by #3846
Assignees
Labels
area/ui Issues that require front-end work team/timber-wolf ui_triage Cross-team/project UI issues for triage

Comments

@joshri
Copy link
Contributor

joshri commented Jun 12, 2023

From #3781

image

This is what I found in Figma if it matters:
image

Policies icons need to be more flexible to support both a hollow (for nav) and filled in (for policies pages) style

@TheGostKasper @AsmaaNabilBakr

@AsmaaNabilBakr
Copy link
Contributor

@TheGostKasper @joshri It’s not possible to use the same icon for outlined and filled icons. I think it would be better to keep them as they are.

@joshri
Copy link
Contributor Author

joshri commented Jun 26, 2023

@TheGostKasper @joshri It’s not possible to use the same icon for outlined and filled icons. I think it would be better to keep them as they are.

Have you tried a className for the fill on the main section (a path) on the magnifying glass/checkmark (I believe they are line tags in the svg)?

@joshri joshri reopened this Jun 26, 2023
@AsmaaNabilBakr AsmaaNabilBakr added the ui_triage Cross-team/project UI issues for triage label Aug 29, 2023
@AsmaaNabilBakr
Copy link
Contributor

@joshri still believe it'll be better to let then as they are, kindly take a look to close this ticket.

@joshri joshri closed this as completed Aug 29, 2023
@yiannistri
Copy link
Contributor

Reopening this issue as it was closed without reaching an optimal solution. @mmoulian can you please create a new Policy icon that we can use for both hollow and filled in styles? Then hand this over to @AsmaaNabilBakr to address this issue? Thank you cc @jpellizzari

@yiannistri yiannistri reopened this Sep 4, 2023
@alfaris
Copy link

alfaris commented Sep 6, 2023

We already have icons with both styles
image

I've putted them on the following link
https://www.figma.com/file/IVHnM9iyeFWpd11evtY8ux/Weave-GitOps?type=design&node-id=19443-1761&mode=design&t=dJUDNTA4Jat10Kan-4

@yiannistri
Copy link
Contributor

@alfaris we don't want to have 2 icons but only 1 icon that can be styled differently. Can you create this for us?

@alfaris
Copy link

alfaris commented Sep 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work team/timber-wolf ui_triage Cross-team/project UI issues for triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants