Add edit icon, modify Pipelines and Delivery icons for EE dark mode #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we need to keep it as it's, there's a huge difference in Icons as but there's a chance to enhance the |
|
Cool - made an issue here - we can't have the same icon twice so the svg will need to support both styles. I will restore the dupe icons in this branch for now |
|
Some tests are failing. The order of imports. |
|
oop thanks Olga - fixed. |
opudrovs
approved these changes
Jun 13, 2023
joshri
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3706
Adding edit icon so EE can supply non-Mui specific colors for dark mode. Adjust Pipelines and Delivery icons for EE dark mode
before:
after:
Unfortunately the Pipelines icon is in a tough spot - the fill on the middle section can not be hardcoded to white, but once it's transparent we get that extra filled-in section on the wings. Needs an adjustment in Figma.
Dark Mode Edit button:
