Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only run npm publish job on weave-gitops repo #4083

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

yiannistri
Copy link
Contributor

What changed?
There's a step in our CI process that pushes an npm package to the GitHub npm registry. This step fails when executed in forks of the repo. This change attempts to only run this step for PRs within the weave-gitops repo.

Why was this change made?
To prevent CI from failing when running in forks.

Copy link

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yiannistri yiannistri merged commit 8b91b02 into main Oct 16, 2023
22 checks passed
@yiannistri yiannistri deleted the prevent-publish-js-on-forks branch October 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants