Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new svg icon as CLusterDiscovery icon #4114

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Add new svg icon as CLusterDiscovery icon #4114

merged 5 commits into from
Nov 2, 2023
+17 −0

Conversation

ahussein3
Copy link
Contributor

Add New Icon for new navigation item ( Cluster Discovery Icon)

@ahussein3 ahussein3 self-assigned this Nov 1, 2023
foot
foot approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced Sources w/ ClusterDiscovery and it seemed to render okay 👍

jpellizzari
jpellizzari approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, since we have other Icons like this, but we don't get the benefit of browser caching when we inline SVG into our JS bundles.

If this were an <img /> tag, the browser would cache the image and our bundle size would be reduced.

@ahussein3 ahussein3 merged commit ea5ab79 into main Nov 2, 2023
19 of 20 checks passed
@ahussein3 ahussein3 deleted the addNewIconForClusterDiscovery branch November 2, 2023 18:13
@weave-gitops-bot weave-gitops-bot mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@jpellizzari jpellizzari jpellizzari approved these changes

@opudrovs opudrovs Awaiting requested review from opudrovs

@joshri joshri Awaiting requested review from joshri

Assignees

@ahussein3 ahussein3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahussein3 @foot @jpellizzari