Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove GitOps Run components #4116

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

yiannistri
Copy link
Contributor

@yiannistri yiannistri commented Nov 1, 2023

Part of #weaveworks/weave-gitops-enterprise#3514

What changed?
As part of deprecating GitOps Run, we also need to remove any components used by it.

Why was this change made?
To ensure we don't have code that is not being used.

How did you validate the change?

make
./bin/gitops --help

Release notes
TBD

Documentation Changes
Already done.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for gitops-io ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/gitops-io/deploys/65426f27489c3011b8c80fa7
😎 Deploy Preview https://deploy-preview-4116--gitops-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yiannistri yiannistri marked this pull request as ready for review November 1, 2023 16:34
@opudrovs
Copy link
Contributor

opudrovs commented Nov 2, 2023

It looks like pkg/run/git_exec.go can be deleted too (unless it is required for some future purposes).

@opudrovs
Copy link
Contributor

opudrovs commented Nov 2, 2023

And I see adding the following command left in enterprise, probably it's related to the whole issue:
https://github.com/weaveworks/weave-gitops-enterprise/blob/7c4384106bd568eb0d191e8849e63ca5b8097016/cmd/gitops/app/root/cmd.go#L141

@yiannistri yiannistri merged commit dc522e3 into main Nov 2, 2023
21 checks passed
@yiannistri yiannistri deleted the remove-gitops-run-libs branch November 2, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants