Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

don't crash on garbage UDP packets #123

Closed
errordeveloper opened this issue Oct 15, 2014 · 3 comments · Fixed by #125
Closed

don't crash on garbage UDP packets #123

errordeveloper opened this issue Oct 15, 2014 · 3 comments · Fixed by #125
Assignees
@rade
Labels
feature

Comments

@errordeveloper
Copy link
Contributor

Drop early and log in debug mode whenever we are dropping.
@errordeveloper
Copy link
Contributor Author

Should we close #120, as this one is higher level?

@rade
Copy link
Member

rade commented Oct 15, 2014

No, #120 is about the specific issue you are seeing. We need to know what is going on there. Why do we see malformed packets? Is there a bug in the network stack? In weave? Something we need to fix/workaround?

@rade rade added the feature label Oct 15, 2014
@rade rade changed the title Weave shouldn't crash when malformed UDP packet arrives don't crash on garbage UDP packets Oct 15, 2014
@rade
Copy link
Member

rade commented Oct 15, 2014

Drop early and log in debug mode whenever we are dropping.

We should always log when we drop, at least for now.

rade added a commit that referenced this issue Oct 15, 2014
@rade
don't trip over truncated udp packets
4ddfc47 
and log such events, plus any other errors during decoding, nicely,
including the connection on which this occured.

Closes #123.
@rade rade mentioned this issue Oct 15, 2014
Merged
bboreham added a commit that referenced this issue Oct 16, 2014
@bboreham
Merge pull request #125 from zettio/123_udp_garbage
6e59006 
LGTM; closes #123
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rade rade

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't trip over truncated udp packets weaveworks/weave
2 participants
@rade @errordeveloper