Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

make weave build & work with go 1.5 #1436

Closed
rade opened this issue Sep 15, 2015 · 4 comments
Closed

make weave build & work with go 1.5 #1436

rade opened this issue Sep 15, 2015 · 4 comments
Labels
Milestone

Comments

@rade
Copy link
Member

rade commented Sep 15, 2015

See #1386 for a failed attempt.

@rade rade added the chore label Sep 15, 2015
@tomwilkie
Copy link
Contributor

Relevant: weaveworks/scope#488

@rade
Copy link
Member Author

rade commented Sep 15, 2015

ah! "The old format still works in 1.5, just spits a warning.". I'd be happy with that, at least for the time being. so it seems we could just resurrectt #1386 minus that change.

@rade
Copy link
Member Author

rade commented Sep 18, 2015

so it seems we could just resurrectt #1386 minus that change.

Actually @dpw only reverted the Makefile change, so there is even less to do here (if anything?)

@dpw
Copy link
Contributor

dpw commented Sep 20, 2015

I've reinstated the other Makefile changes that weren't responsible for the problems with 1.4: a67b9f5

So now we have all of #1386 back, except for the -X change, which just means we get a warning with go-1.5.

@dpw dpw closed this as completed Sep 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants