Compile flags compatible with 1.4 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Symptom is version number doesn't appear in UI. |
|
There's no reason not to tell everyone to upgrade to 1.5. There's no value in backwards compatibility. But, of course this change is tiny and it doesn't really matter. So LGTM. |
|
Yeah I was thinking after 0.7 is out we should all upgrade to go1.5. Only reason not to do it now is it will require some CI work. |
tomwilkie
added a commit
that referenced
this pull request
Sep 16, 2015
Compile flags compatible with 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #440 we changed the build flags that inject the version number to work with go1.5; but the new format doesn't work with go1.4.
The old format still works in 1.5, just spits a warning. Lets stick with the old format until everyone has moved to go1.5.