Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

running eval $(weave env) multiple times breaks eval $(weave env --restore) #1824

Closed
rade opened this issue Dec 22, 2015 · 2 comments
Closed
Labels
Milestone

Comments

@rade
Copy link
Member

rade commented Dec 22, 2015

root@xps:~# weave launch
root@xps:~# eval $(weave env)
root@xps:~# eval $(weave env)
root@xps:~# weave reset
WARNING: It appears that your environment is configured to use the Weave Docker API proxy. Stopping it will break this and subsequent docker invocations. To restore your environment, run 'eval $(weave env --restore)'.
Error deleting container: Cannot connect to the Docker daemon. Is 'docker -d' running on this host?
Cannot connect to the Docker daemon. Is 'docker -d' running on this host?
root@xps:~# eval $(weave env --restore)
root@xps:~# docker ps
Cannot connect to the Docker daemon. Is 'docker -d' running on this host?
root@xps:~# eval $(weave env --restore)
root@xps:~# docker ps
Cannot connect to the Docker daemon. Is 'docker -d' running on this host?

I reckon eval $(weave env) should be made idempotent.

@rade rade added the chore label Dec 22, 2015
@Corwin7
Copy link

Corwin7 commented Dec 22, 2015

I ran into this.

@rade rade added this to the 1.4.2 milestone Dec 23, 2015
bboreham added a commit that referenced this issue Dec 23, 2015
make `eval $(weave env)` idempotent; LGTM.  Fixes #1824
@rade rade closed this as completed in c7c669f Dec 23, 2015
@Corwin7
Copy link

Corwin7 commented Dec 24, 2015

Thanks for fixing this so fast! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants