Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

weave-npc race condition between AddNamespace and AddNetworkPolicy Events #3059

Closed
mikebryant opened this issue Jul 12, 2017 · 0 comments
Closed

Comments

@mikebryant
Copy link
Collaborator

What you expected to happen?

For weave-npc to maintain ipsets

What happened?

If the AddNetworkPolicy event is seen before the AddNamespace event (happens intermittently on startup for us) then the NamespaceSelector ipset doesn't include the individual Namespace ipsets

How to reproduce it?

Run the test in #3057

Versions:

$ weave version
$ docker version
$ uname -a
$ kubectl version

weave 2.0.1

mikebryant added a commit that referenced this issue Jul 12, 2017
If we have namespaces Source and Destination, and Destination
contains a NetworkPolicy allowing access from Source, we need
to provision the ipsets for Source and add them to relevant
selectors, even though Source is DefaultAllow.

Fixes #3059
mikebryant added a commit that referenced this issue Jul 12, 2017
If we have namespaces Source and Destination, and Destination
contains a NetworkPolicy allowing access from Source, we need
to provision the ipsets for Source and add them to relevant
selectors, even though Source is DefaultAllow.

This also fixes an issue where if the Namespace labels are updated,
that would be ignored.

Fixes #3059
mikebryant added a commit that referenced this issue Jul 13, 2017
If we have namespaces Source and Destination, and Destination
contains a NetworkPolicy allowing access from Source, we need
to provision the ipsets for Source and add them to relevant
selectors, even though Source is DefaultAllow.

This also fixes an issue where if the Namespace labels are updated,
that would be ignored.

Fixes #3059
@bboreham bboreham added this to the 2.0.2 milestone Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants