Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Add a metric for NPC errors #3791

Closed
bboreham opened this issue Mar 26, 2020 · 0 comments · Fixed by #3804
Closed

Add a metric for NPC errors #3791

bboreham opened this issue Mar 26, 2020 · 0 comments · Fixed by #3804
Labels
[component/policy]

Comments

@bboreham
Copy link
Contributor

In #3790 we are making some errors non-fatal; while inconvenient to have the process crash-looping at least it was easy to spot.

So, I suggest adding a Prometheus counter for errors inside NPC, so that this can be monitored and alerted on.
murali-reddy added a commit that referenced this issue Apr 16, 2020
@murali-reddy
introduce weavenpc_policy_enforcement_errors prometheus metric
57ca214 
to track number of errors occured during enforcing network policies

Fixes #3791
@murali-reddy murali-reddy mentioned this issue Apr 16, 2020
Closed
murali-reddy added a commit that referenced this issue Apr 16, 2020
@murali-reddy
introduce weavenpc_policy_enforcement_errors prometheus metric
bc02cb7 
to track number of errors occured during enforcing network policies

Fixes #3791
@bboreham bboreham mentioned this issue May 22, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
[component/policy]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metric for NPC errors weaveworks/weave
metric for NPC errors weaveworks/weave
1 participant
@bboreham