This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Proxy restart shouldn't kill containers #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please split part 2 into a separate issue and PR - I doubt that is going to make it into 1.2.0, whereas part 1 should. |
paulbellamy
force-pushed
the
1547-proxy-restart-no-kill-containers
branch
from
89ed4c2 to
a0f0367
Compare
paulbellamy
changed the title
| for _, apiContainer := range containers { | ||
| container, err := proxy.client.InspectContainer(apiContainer.ID) | ||
| if err != nil { | ||
| Log.Warningf("unable to attach existing container %s since inspecting it failed: %v", apiContainer.ID, err) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
1547-proxy-restart-no-kill-containers
branch
from
07ae38a to
ace6c01
Compare
rade
added a commit
that referenced
this pull request
Oct 19, 2015
…ontainers Proxy restart shouldn't kill containers Fixes #1547.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1547.
First commit stops it killing containers when restarting the proxy.
Second adds a first pass at an attachment retry mechanism. Thoughts on that? I need to have a think about how to test it.