Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Update unit test for miekg DNS API change #1622

Merged
merged 2 commits into from
Nov 2, 2015
Merged

Update unit test for miekg DNS API change #1622

merged 2 commits into from
Nov 2, 2015

Conversation

awh
Copy link
Contributor

@awh awh commented Nov 2, 2015

Fix unit test breakage caused by miekg/dns@2d2c2eb

@awh awh added this to the 1.2.1 milestone Nov 2, 2015
@awh awh assigned awh and rade and unassigned awh Nov 2, 2015
@tomwilkie
Copy link
Contributor

Is there anyway we could have prevented this? :trollface:

@bboreham bboreham assigned bboreham and unassigned rade Nov 2, 2015
@bboreham
Copy link
Contributor

bboreham commented Nov 2, 2015

Do you think we should also check for ErrTruncated in handleRecursive()? ISTM that it's better to return a truncated response than no response at all. Also more faithful to other DNS implementations.

@bboreham bboreham assigned awh and unassigned bboreham Nov 2, 2015
@awh
Copy link
Contributor Author

awh commented Nov 2, 2015

Do you think we should also check for ErrTruncated in handleRecursive()?

Good spot - I have pushed an update.

@awh awh assigned bboreham and unassigned awh Nov 2, 2015
bboreham added a commit that referenced this pull request Nov 2, 2015
@bboreham
Merge pull request #1622 from weaveworks/fix-miekg-dns-truncation-test
2bbe6a2 
LGTM
@bboreham bboreham merged commit 2bbe6a2 into 1.2 Nov 2, 2015
@awh awh deleted the fix-miekg-dns-truncation-test branch November 9, 2015 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bboreham bboreham

Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@awh @tomwilkie @bboreham @rade