This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
remove UnknownPeerError for quicker convergence and efficiency #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
force-pushed
the
remove-unknown-peer-error
branch
from
4cd78af to
29cb566
Compare
when encountering an unknown peer in received gossip, rather than ignoring the entire gossip we create a placeholder Peer. This has version 0 and uid 0, which means it will be replaced by any complete peer information subsequently received via gossip.
rade
force-pushed
the
remove-unknown-peer-error
branch
from
29cb566 to
7e15eab
Compare
rade
changed the title
This is more efficient since broadcasting about other peers is strictly redundant. Any change to the peers will be broadcast by those peers anyway. And SendAllGossipDown takes care of informing new peers about others on first connect, and periodic gossip take care of missed broadcasts. The only reason we did broadcast about the remote peer is to reduce the liklihood of UnknownPeerError and the associated throwing away of gossip. This was always a bit of kludge, and is no longer necessary since UnknownPeerError is gone. Now peers only ever broadcast information about themselves. Which, unlike information about other peers, is always authorative and most up-to-date. Which is nice.
|
There is one user-visible consequence of this change: occasionally, and usually briefly, |
rade
changed the title
bboreham
force-pushed
the
remove-unknown-peer-error
branch
from
8c73249 to
cbb2ad0
Compare
bboreham
added a commit
that referenced
this pull request
Dec 4, 2015
remove UnknownPeerError for quicker convergence and efficiency. LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering an unknown peer in received gossip, rather than ignoring the entire gossip we create a placeholder Peer. This has version 0 and uid 0, which means it will be replaced by any complete peer information subsequently received via gossip.
Not ignoring the gossip results in quicker convergence.
We also no longer need to broadcast about the remote peer when adding a connection, since we only did that in order to reduce the occurrence of
UnknownPeerErrors. Not needing to do this is is more efficient, since the broadcast was strictly redundant.