This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Remove proxy status.sock #2960
Merged
Remove proxy status.sock #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the previous version was de-newlined by the shell and the new version isn't. Since I can't figure out the exact reason the shell is now behaving differently (man page says it depends on the quoting that is in effect) I brute-force it with 'tr'.
5 tasks
marccarre
reviewed
May 15, 2017
prog/weaver/main.go
Outdated
| @@ -441,6 +442,7 @@ func main() { | |||
| HandleHTTP(muxRouter, version, router, allocator, defaultSubnet, ns, dnsserver, &waitReady) | |||
| HandleHTTPPeer(muxRouter, allocator, discoveryEndpoint, token, name.String()) | |||
| muxRouter.Methods("GET").Path("/metrics").Handler(metricsHandler(router, allocator, ns, dnsserver)) | |||
| muxRouter.Methods("GET").Path("/proxyaddrs").HandlerFunc(proxy.StatusHTTP) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hold-over from the multi-container implementation, so we can slim things down a bit by removing it.
Although #2036 recommends going in the opposite direction 🤔