This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Fix various CI failures #3061
Merged
Fix various CI failures #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccarre
approved these changes
Jul 12, 2017
Previously we used 'alpine' which had no 'CMD' line, but that changed upstream, so generate our own trivial image for this purpose.
Before this change, when using Docker 17.06 we get:
tests/integration/container_test.py:121: in test_create_with_restart_policy
'You cannot remove a running container', err
E AssertionError: 'You cannot remove a running container' not found in u'You cannot remove a restarting container
The modified image simply checks for "You cannot remove a".
bboreham
changed the title
marccarre
approved these changes
Jul 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Upgrade tools submodule and move to Docker 17.06
Lots of failures with defunct processes: these come from an Ubuntu update job, so I disabled that in weaveworks/build-tools#108.
However we are unable to install Docker 1.13 the way we used to, because the package has been removed from the script we used. Also not many people use Docker 1.13 so it's not a very good basis for our CI tests.
Therefore I have upgraded all the way to the latest Docker 17.06.
2. Test 360 failed due to not seeing a particular error message.
This is due to an upstream change in the
alpineimage, so I made another image to trigger the error.3. Test 603 failed due to Docker generating a different error message.
I made my own docker-py image which works with either