fix: Missing nil checks #3096

mikebryant · 2017-08-23T00:22:24Z

npc/rule.go

+	}
+	dstComment := "anywhere"
+	if dstHost != nil {
+		dstComment = fmt.Sprintf("pods: namespace: %s, selector: %s", dstHost.nsName, dstHost.key)


bboreham · 2017-08-23T11:05:02Z

Thanks @mikebryant !

fix: Missing nil checks

2555e49

Fixes #3095

rade reviewed Aug 23, 2017

View reviewed changes

npc/rule.go Outdated

}

dstComment := "anywhere"

if dstHost != nil {

dstComment = fmt.Sprintf("pods: namespace: %s, selector: %s", dstHost.nsName, dstHost.key)

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

Fix review comments

de1d409

bboreham added this to the 2.0.3 milestone Aug 23, 2017

bboreham mentioned this pull request Aug 23, 2017

Extend weave-kube smoke test: add a policy with blank 'from' #3097

Merged

bboreham merged commit c2a224b into 2.0 Aug 23, 2017

mikebryant deleted the wip-3095 branch August 23, 2017 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Missing nil checks #3096

fix: Missing nil checks #3096

mikebryant commented Aug 23, 2017

This comment was marked as abuse.

This comment was marked as abuse.

bboreham commented Aug 23, 2017

fix: Missing nil checks #3096

fix: Missing nil checks #3096

Conversation

mikebryant commented Aug 23, 2017

This comment was marked as abuse.

This comment was marked as abuse.

bboreham commented Aug 23, 2017