Use nice-grpc-client-middleware-retry for auto-retry of UNAVAILABLE grpc error
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmith023
changed the title
nice-grpc-retry-middleware for auto-retry of UNAVAILABLE grpc errornice-grpc-client-middleware-retry for auto-retry of UNAVAILABLE grpc error
antas-marcin
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
Instead of using custom grpc keep alive options, as was attempted in #216, which may not be fully generalisable to all cases, this PR introduces
nice-grpc-client-middleware-retryto instead simply retry anyUNAVAILABLEerrors with exponential backoff andN=5in the hope that such transient errors go away