Fixes rollup issues - Build failing with Node v20 and Microsoft PowerApps editor hanging #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanel Metsar <taneltm@users.noreply.github.com>
WE2-907 Signed-off-by: Tanel Metsar <taneltm@users.noreply.github.com>
mrts
approved these changes
Apr 2, 2024
mrts
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Build failing with Node v20
Bundling with Rollup failed with exit code
1.Piping stdout and stderr, ignoring stdin, while executing Rollup doesn't seem to behave as expected.
Changed from piping to
stdio: 'inherit'to fix the issue. This is an old option and should be more stable in any Node version.Fix: Microsoft PowerApps editor hangs on loading screen
Rollup plugin
injectProcessEnvwas used while compilingtoken-signing-page-script.js.That script is injected to the page when TokenSigning backwards compatibility is turned on.
It then included code which made the PowerApps editor think it's code was running in Node.js (more specifically in Linux or Mac) instead of the browser, and then crashed.
After the change,
injectProcessEnvplugin is only used while compiling the code which runs in the WebExtension context and doesn't interfere with the website's code.