Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(builder): fix progress log e2e test #4678

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Sep 19, 2023

Summary

🤖 Generated by Copilot at 5ae0c00

Updated e2e test for progress bar to use new API and logger names.

Details

🤖 Generated by Copilot at 5ae0c00

  • Rename logger methods and update test variables to match new progress bar API (link)
  • Adjust test assertions to match new progress bar messages (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: 5ae0c00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.86% ⚠️

Comparison is base (99693f0) 57.59% compared to head (5ae0c00) 53.74%.
Report is 1175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4678      +/-   ##
==========================================
- Coverage   57.59%   53.74%   -3.86%     
==========================================
  Files         672      664       -8     
  Lines       17794    18092     +298     
  Branches     3876     4143     +267     
==========================================
- Hits        10249     9723     -526     
- Misses       6934     7712     +778     
- Partials      611      657      +46     

see 468 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenjiahan chenjiahan merged commit dff7960 into web-infra-dev:main Sep 19, 2023
9 checks passed
@chenjiahan chenjiahan deleted the builder_e2e_0919 branch September 19, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant