Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools/doctor): compatible with web doctor implementation #5378

Conversation

Asuka109
Copy link
Contributor

@Asuka109 Asuka109 commented Feb 7, 2024

Summary

img_v3_0286_3c0b231d-7e2b-4a45-a502-6795015e58eg

  • Resolve and display package version.
  • Compatible with web doctor implementation.
  • Remove the file size indicator from the doctor page to prevent users from being confused by the development output file size.
  • Show formatted time cost.

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 2a1db3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Asuka109 Asuka109 changed the base branch from main to dev/devtools-integrate-doctor February 18, 2024 08:57
@Asuka109 Asuka109 changed the title [WIP] feat: binding data feat(devtools/doctor): compatible with web doctor implementation Feb 18, 2024
@chenjiahan chenjiahan merged commit 21b506c into web-infra-dev:dev/devtools-integrate-doctor Feb 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants