-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(solutions): separate generator from solutions #5420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a99aa24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!canary |
KyrieLii
force-pushed
the
feat-separate-generator-from-solutions
branch
from
February 21, 2024 07:48
8cd2ef9
to
b31a08c
Compare
!canary |
1 similar comment
!canary |
KyrieLii
force-pushed
the
feat-separate-generator-from-solutions
branch
2 times, most recently
from
February 26, 2024 07:17
496caa8
to
fde81da
Compare
KyrieLii
force-pushed
the
feat-separate-generator-from-solutions
branch
from
February 28, 2024 06:15
b64b2d8
to
a99aa24
Compare
KyrieLii
changed the title
Feat separate generator from solutions
feat(solutions): separate generator from solutions
Feb 28, 2024
zllkjc
reviewed
Feb 28, 2024
zllkjc
approved these changes
Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #5359
1. Background
This PR made some optimizations by separating the 'new' and 'upgrade' commands from solutions (such as app-tools).
There are several benefits to doing this:
2. Design
2.1 Refactor @modern-js/new-action and @modern-js/upgrade to make them run independently.
Now you can use it by
npx
:After refactoring, the original invocation method remains unaffected.
2.2 Remove the above two dependencies from solutions and execute the CLI using the npx method.
To maintain version consistency, a new environment variable MODREN_JS_VERSION has been added during execution.
3. Drawback
The first time executing the command will take longer, as the time cost has shifted to the npx execution.
Whenever the version of solutions changes, it can be considered as the first time executing.
Next, We will optimize the execution speed of the cli based on this foundation.
Related Links
Checklist
pnpm run change
.