Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove devtools field from app tools configurations #6513

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

Asuka109
Copy link
Contributor

@Asuka109 Asuka109 commented Nov 7, 2024

Summary

Remove useless devtools field from configurations.

This pull request includes a small change to the AppToolsUserConfig interface in the packages/solutions/app-tools/src/types/config/index.ts file. The change removes the devtools property from the interface.

Related Links

Checklist

No need changeset here.

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: efa41bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit efa41bd
🔍 Latest deploy log https://app.netlify.com/sites/modernjs-byted/deploys/675185d041e4ea0009917cac
😎 Deploy Preview https://deploy-preview-6513--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Asuka109 Asuka109 merged commit 43fd1b3 into web-infra-dev:main Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants