Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace output.targets with output.target #2636

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented Jun 19, 2024

Summary

  • breaking change: Replace output.targets with output.target
  • chore: Generate rspack / webpack config based on environment instead of output.targets

Each environment has and only corresponds to one target. Multiple environments can have the same target.

one environment = one rsbuild configuration = one rspack configuration = one build outputs.

image

Related Links

#2620

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e0e7bef
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6673c5e7ac0a4c0008311549
😎 Deploy Preview https://deploy-preview-2636--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title refactor: replace output.targets with output.target breaking change: replace output.targets with output.target Jun 19, 2024
@chenjiahan
Copy link
Member

Please add to: #2508

9aoy and others added 4 commits June 20, 2024 11:41
@chenjiahan chenjiahan enabled auto-merge (squash) June 20, 2024 06:07
@chenjiahan chenjiahan merged commit ddf8cea into main Jun 20, 2024
10 checks passed
@chenjiahan chenjiahan deleted the refactor-output-target branch June 20, 2024 06:09
@chenjiahan chenjiahan changed the title breaking change: replace output.targets with output.target feat!: replace output.targets with output.target Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants