Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated dev.startUrl #2642

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

Remove the deprecated dev.startUrl config, use server.open instead.

Reference

#2508

Changes:

  • Rename dev.startUrl to server.open.
  • Rename dev.beforeStartUrl to server.open.before.

Motivation:

  • Align with Rspack dev server's open config.
  • Allow to use in the preview server.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c7cc562
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6673cd580bbda10008db62c8
😎 Deploy Preview https://deploy-preview-2642--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title breaking change: remove deprecated dev.startUrl feat!: remove deprecated dev.startUrl Jun 20, 2024
@chenjiahan chenjiahan merged commit b4ed6c1 into main Jun 20, 2024
12 checks passed
@chenjiahan chenjiahan deleted the remove_start_url_0620 branch June 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant