Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): register OPTIONS fallback middleware at last #2885

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

chenjiahan
Copy link
Member

Summary

  • Change the status code from 200 to 204, because server does not response any data.
  • Move the middleware to the last as a fallback.

Related Links

#2867
webpack/webpack-dev-server#4559

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6adc714
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668fdf51ab009e0008cde4c1
😎 Deploy Preview https://deploy-preview-2885--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit a4574a4 into main Jul 11, 2024
10 checks passed
@chenjiahan chenjiahan deleted the middleware_order_0711 branch July 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant