-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support add plugins for specified environment #2986
Merged
chenjiahan
merged 10 commits into
web-infra-dev:main
from
9aoy:feat/environment-plugins
Jul 23, 2024
Merged
feat: support add plugins for specified environment #2986
chenjiahan
merged 10 commits into
web-infra-dev:main
from
9aoy:feat/environment-plugins
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Jul 22, 2024
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
Co-authored-by: neverland <jait.chen@foxmail.com>
chenjiahan
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
easy1090
added a commit
that referenced
this pull request
Jul 23, 2024
fix: rsdoctor plugin fix: rsdoctor plugin feat: support add plugins for specified environment (#2986) Co-authored-by: neverland <jait.chen@foxmail.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> fix: modify the criteria for verifying the Rsdoctor plugin.
easy1090
added a commit
that referenced
this pull request
Jul 23, 2024
fix: rsdoctor plugin fix: rsdoctor plugin feat: support add plugins for specified environment (#2986) Co-authored-by: neverland <jait.chen@foxmail.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> fix: modify the criteria for verifying the Rsdoctor plugin.
2 tasks
easy1090
added a commit
that referenced
this pull request
Jul 23, 2024
fix: rsdoctor plugin fix: rsdoctor plugin feat: support add plugins for specified environment (#2986) Co-authored-by: neverland <jait.chen@foxmail.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> Update packages/core/src/plugins/rsdoctor.ts Co-authored-by: neverland <chenjiahan.jait@bytedance.com> fix: modify the criteria for verifying the Rsdoctor plugin. fix: modify the criteria for verifying the Rsdoctor plugin.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support add plugins for specified environment.
For example, enable the react plugin only in the web environment:
TODO: Some plugins do not yet support single-environment registration because they use
api.modifyRsbuildConfig
hook to modify the global configuration.Related Links
#2620
Checklist