Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy type error #3936

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: proxy type error #3936

merged 1 commit into from
Nov 11, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Nov 11, 2024

Summary

The proxy type of http-proxy-middleware refers to express, but express is not actually used in rsbuild.

This problem will be temporarily fixed in the prebundle. To completely fix this problem I think we need to upgrade to http-proxy-middleware v3 (maybe rsbuild v2)

Related Links

fix: #3924

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 9c498d9
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6731a735e730cd0008006412
😎 Deploy Preview https://deploy-preview-3936--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 63 (🔴 down 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit ca7f90b into main Nov 11, 2024
11 checks passed
@chenjiahan chenjiahan deleted the fix/proxy-type branch November 11, 2024 07:00
@9aoy 9aoy mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: onProxyReq: function(proxyReq, req, res) res.redirect is not a function
2 participants