Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: count in optionalDependencies in autoExternal. #266

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: count in optionalDependencies in autoExternal. #266

merged 3 commits into from
Oct 10, 2024

Conversation

fi3ework
Copy link
Member

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Timeless0911
Timeless0911 reviewed Oct 10, 2024
View reviewed changes
.nvmrc Outdated Show resolved Hide resolved
@fi3ework
Revert "ci: node version"
f9fca30 
This reverts commit fad1376.
@fi3ework
Copy link
Member Author

fi3ework commented Oct 10, 2024 •
edited
Loading

Benchmark CI failed due to the upgrade in https://github.com/CodSpeedHQ/action/blob/016456b513677f9d4a1c509c7f8a38d8dd55b2b0/.github/workflows/ci.yml#L19. Will fix in next PR, merge this ahead.

@fi3ework fi3ework merged commit 93d150d into main Oct 10, 2024
9 of 10 checks passed
@fi3ework fi3ework deleted the ae branch October 10, 2024 06:20
@Timeless0911
Copy link
Collaborator

Benchmark CI failed due to the upgrade in CodSpeedHQ/action@016456b/.github/workflows/ci.yml#L19. Will fix in next PR, merge this ahead.

@SoonIter cc

@fi3ework fi3ework mentioned this pull request Oct 10, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @Timeless0911