Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: should check deps of all package.json #302

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Oct 17, 2024

Summary

Now check-dependency-version-consistency only works in packages/* folder, we need to cover all of the packages folder.

Since both changeset and check-dependency-version-consistency will read workspaces field in package.json, this PR have done such thing:

  • Add more packages glob pattern to workspaces.packages
  • Config privatePackages field of .changeset/config.json to disable bump private packages
  • Modify the test script of tests/integration/cli/index.test.ts since after adding tests/** to workspaces.packages field, npx rslib inspect will report an error
npm ERR! could not determine executable to run

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit c5ce856
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6710bc380d5f9d000957b9ef
😎 Deploy Preview https://deploy-preview-302--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #302 will not alter performance

Comparing chore/check-deps (c5ce856) with main (f4bb341)

Summary

✅ 4 untouched benchmarks

package.json Show resolved Hide resolved
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary pls 👀

@Timeless0911
Copy link
Collaborator Author

PR Summary pls 👀

Just editing before

@Timeless0911 Timeless0911 merged commit f9f1751 into main Oct 17, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the chore/check-deps branch October 17, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants