Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use global as mf format external type #331

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: use global as mf format external type #331

merged 2 commits into from
Oct 28, 2024

Conversation

nyqykk
Copy link
Member

@nyqykk nyqykk commented Oct 25, 2024 •
edited by Timeless0911
Loading

Summary

vmok uses global by default.

When users use a external pkg like '@xxx', this will be transform to

var xxx = @xxx

which will cause syntax Error because there's no quotation marks. So set to global to avoid this

Related Links

close: #330

@nyqykk nyqykk mentioned this pull request Oct 25, 2024
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #331 will not alter performance

Comparing fix/mf-external-type (828abcd) with main (3a68db0)

Summary

✅ 5 untouched benchmarks

@nyqykk nyqykk enabled auto-merge (squash) October 28, 2024 03:48
@nyqykk nyqykk merged commit caf5d69 into main Oct 28, 2024
19 checks passed
@nyqykk nyqykk deleted the fix/mf-external-type branch October 28, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework left review comments

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot build if import package name include '@'
3 participants
@nyqykk @fi3ework @Timeless0911