Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-rslib): preserve @rslib/core as workspace #346

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(create-rslib): preserve @rslib/core as workspace #346

merged 1 commit into from
Oct 30, 2024

Conversation

fi3ework
Copy link
Member

Summary

  • leave workspace:* to the final step.
  • bump testing library

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 4ba936e
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6721fd646c68e80008272d60
😎 Deploy Preview https://deploy-preview-346--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Contributor

What is it mean? The template will be published?

Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #346 will not alter performance

Comparing aaaa (4ba936e) with main (6432229)

Summary

✅ 5 untouched benchmarks

@fi3ework
Copy link
Member Author

What is it mean? The template will be published?

No, previously, the version of @rslib/core in template is a fixed version like ^0.0.15 which is wrong. I should be workspace:* as before. workspace:* will be replaced to the correct vesion in runtime.

@Timeless0911
Copy link
Contributor

workspace:* will be replaced to the correct vesion in runtime.

Where is this logic?

@fi3ework
Copy link
Member Author

fi3ework commented Oct 30, 2024

Where is this logic?

Inside create-rstack, we just need to ensure reserve workspace:* in template before create-rstack execute.

@fi3ework fi3ework enabled auto-merge (squash) October 30, 2024 10:23
@fi3ework fi3ework merged commit cad22af into main Oct 30, 2024
20 checks passed
@fi3ework fi3ework deleted the aaaa branch October 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants