Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export composeCreateRsbuildConfig as utils #367

Merged
merged 4 commits into from
Nov 4, 2024
Merged

chore: export composeCreateRsbuildConfig as utils #367

merged 4 commits into from
Nov 4, 2024

Conversation

nyqykk
Copy link
Member

@nyqykk nyqykk commented Nov 4, 2024

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@nyqykk nyqykk enabled auto-merge (squash) November 4, 2024 08:27
chenjiahan
chenjiahan reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful about exporting public APIs, and all public APIs should be documented later.

For private APIs, use prefixes like _ or _internal.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #367 will not alter performance

Comparing chore/export-utils (3e06d99) with main (d5d5bb5)

Summary

✅ 5 untouched benchmarks

fi3ework
fi3ework reviewed Nov 4, 2024
View reviewed changes
packages/core/src/index.ts Outdated Show resolved Hide resolved
@nyqykk nyqykk merged commit f23ae2d into main Nov 4, 2024
20 checks passed
@nyqykk nyqykk deleted the chore/export-utils branch November 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@fi3ework fi3ework fi3ework approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyqykk @chenjiahan @fi3ework