-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support lib.id #436
feat: support lib.id #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- website/docs/en/config/lib/_meta.json: Language not supported
- website/docs/en/config/lib/id.mdx: Language not supported
- website/docs/en/guide/basic/cli.mdx: Language not supported
Comments skipped due to low confidence (1)
packages/core/src/config.ts:1314
- The error message for duplicated IDs could be more informative. Consider specifying which IDs are duplicated and suggesting how to resolve the conflict.
throw new Error('The following ids are duplicated: ${conflictIds.map((id) => `"${id}"`).join(', ')}. Please make sure each lib has a unique id.');
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- website/docs/en/config/lib/_meta.json: Language not supported
- website/docs/en/config/lib/id.mdx: Language not supported
- website/docs/en/guide/basic/cli.mdx: Language not supported
CodSpeed Performance ReportMerging #436 will not alter performanceComparing Summary
|
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
Summary
Close #382.
Support configure
lib.id
in userland.Related Links
Checklist