Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lib.id #436

Merged
merged 5 commits into from
Nov 18, 2024
Merged

feat: support lib.id #436

merged 5 commits into from
Nov 18, 2024

Conversation

fi3ework
Copy link
Member

Summary

Close #382.

Support configure lib.id in userland.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • website/docs/en/config/lib/_meta.json: Language not supported
  • website/docs/en/config/lib/id.mdx: Language not supported
  • website/docs/en/guide/basic/cli.mdx: Language not supported
Comments skipped due to low confidence (1)

packages/core/src/config.ts:1314

  • The error message for duplicated IDs could be more informative. Consider specifying which IDs are duplicated and suggesting how to resolve the conflict.
throw new Error('The following ids are duplicated: ${conflictIds.map((id) => `"${id}"`).join(', ')}. Please make sure each lib has a unique id.');
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit a0f20a0
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/673ad917407aca0008ba7690
😎 Deploy Preview https://deploy-preview-436--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • website/docs/en/config/lib/_meta.json: Language not supported
  • website/docs/en/config/lib/id.mdx: Language not supported
  • website/docs/en/guide/basic/cli.mdx: Language not supported
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #436 will not alter performance

Comparing id (8efe84b) with main (190ca7c)

Summary

✅ 5 untouched benchmarks

fi3ework and others added 3 commits November 18, 2024 14:05
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
@Timeless0911 Timeless0911 enabled auto-merge (squash) November 18, 2024 06:13
@Timeless0911 Timeless0911 merged commit fe69381 into main Nov 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: named config and positive filter
2 participants