fix: output should be consistent when using splitChunks (#8425)

crates/rspack_plugin_split_chunks/src/plugin/max_size.rs

@@ -6,7 +6,8 @@ use regex::Regex;
 use rspack_collections::{DatabaseItem, UkeyMap};
 use rspack_core::incremental::Mutation;
 use rspack_core::{
-  ChunkUkey, Compilation, CompilerOptions, Module, ModuleIdentifier, DEFAULT_DELIMITER,
+  compare_modules_by_identifier, ChunkUkey, Compilation, CompilerOptions, Module, ModuleIdentifier,
+  DEFAULT_DELIMITER,
 };
 use rspack_error::Result;
 use rspack_hash::{RspackHash, RspackHashDigest};
@@ -83,10 +84,12 @@ fn deterministic_grouping_for_modules(
 ) -> Vec<Group> {
   let mut results: Vec<Group> = Default::default();
   let module_graph = compilation.get_module_graph();
-  let items = compilation
+  let mut items = compilation
     .chunk_graph
     .get_chunk_modules(chunk, &module_graph);
 
+  items.sort_unstable_by(|a, b| compare_modules_by_identifier(a, b));
+
   let context = compilation.options.context.as_ref();
 
   let nodes = items.into_iter().map(|module| {
@@ -183,6 +186,7 @@ fn deterministic_grouping_for_modules(
       if left <= right {
         let right_nodes = group.nodes.split_off(left);
         let left_nodes = group.nodes;
+
         queue.push(Group::new(right_nodes, None));
         queue.push(Group::new(left_nodes, None));
       }

packages/rspack-test-tools/tests/compilerCases/consistent.js

@@ -0,0 +1,45 @@
+const stats = [];
+
+/** @type {import('../../dist').TCompilerCaseConfig} */
+module.exports = {
+	description: "should be called every compilation",
+	options(context) {
+		return {
+			context: context.getSource(),
+			entry: "./split-chunks/src/index.js",
+			optimization: {
+				splitChunks: {
+					chunks: 'all',
+					minSize: 100 * 1024,
+					maxSize: 200 * 1024,
+				}
+			},
+			stats: {
+				assets: true
+			}
+		};
+	},
+	async build(_, compiler) {
+		await new Promise(resolve => {
+			compiler.run((err, stat) => {
+				if (err) {
+					throw err
+				}
+				stats.push(stat.toJson().assets)
+				compiler.run((_, stat) => {
+					stats.push(stat.toJson().assets)
+					compiler.run((_, stat) => {
+						stats.push(stat.toJson().assets)
+						resolve();
+					});
+				});
+			});
+		});
+	},
+	async check() {
+		const stats1 = stats[0].reduce((acc, curr) => acc + curr.name, '')
+		const stats2 = stats[1].reduce((acc, curr) => acc + curr.name, '')
+		const stats3 = stats[2].reduce((acc, curr) => acc + curr.name, '')
+		expect(stats1 === stats2 === stats3);
+	}
+};

packages/rspack-test-tools/tests/fixtures/split-chunks/src/index.js

@@ -0,0 +1,59 @@
+import { createElement } from "react";
+import { render } from "react-dom";
+import { fiftyK } from "./50k";
+import { fiftyK as fiftyK_1 } from "./50k-1";
+import { fiftyK as fiftyK_2 } from "./50k-2";
+import { fiftyK as fiftyK_3 } from "./50k-3";
+import { fiftyK as fiftyK_4 } from "./50k-4";
+import { fiftyK as fiftyK_5 } from "./50k-5";
+import { fiftyK as fiftyK_6 } from "./50k-6";
+import { fiftyK as fiftyK_7 } from "./50k-7";
+import { fiftyK as fiftyK_8 } from "./50k-8";
+
+import {
+  fiftyK1,
+  fiftyK2,
+  fiftyK3,
+  fiftyK4,
+  fiftyK5,
+  fiftyK6,
+  fiftyK7,
+  fiftyK8,
+} from "./400k";
+
+import axios from "axios";
+import dayjs from "dayjs";
+import * as ReactUse from "react-use";
+import * as ahooks from "ahooks";
+
+window.lib = {
+  axios,
+  dayjs,
+  ReactUse,
+  ahooks,
+  fiftyK,
+  fiftyK1,
+  fiftyK2,
+  fiftyK3,
+  fiftyK4,
+  fiftyK5,
+  fiftyK6,
+  fiftyK7,
+  fiftyK8,
+  fiftyK_1,
+  fiftyK_2,
+  fiftyK_3,
+  fiftyK_4,
+  fiftyK_5,
+  fiftyK_6,
+  fiftyK_7,
+  fiftyK_8,
+};
+
+render(
+  createElement("div", null, [
+    createElement("h1", null, `Hello World  ${__BUNDLE__}`),
+    createElement("p", null, "see more detail in devtool/network"),
+  ]),
+  document.getElementById("root")
+);