fix: do not use affected for side-effects-flag-plugin (#7865)

fix: do not use cacheUnaffected for side-effects-flag-plugin

crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs

@@ -656,23 +656,13 @@ async fn nmf_module(
 
 #[plugin_hook(CompilationOptimizeDependencies for SideEffectsFlagPlugin)]
 fn optimize_dependencies(&self, compilation: &mut Compilation) -> Result<Option<bool>> {
-  let mut modules: IdentifierSet = if compilation.options.new_incremental_enabled() {
-    compilation
-      .unaffected_modules_cache
-      .get_affected_modules_with_module_graph()
-      .lock()
-      .expect("should lock")
-      .iter()
-      .copied()
-      .collect()
-  } else {
-    compilation
-      .get_module_graph()
-      .modules()
-      .keys()
-      .copied()
-      .collect()
-  };
+  // TODO: use affected module optimization
+  let mut modules: IdentifierSet = compilation
+    .get_module_graph()
+    .modules()
+    .keys()
+    .copied()
+    .collect();
   let mut new_connections = Default::default();
   for module in modules.clone() {
     optimize_incoming_connections(module, &mut modules, &mut new_connections, compilation);

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/__snapshots__/web/0.snap.txt

@@ -0,0 +1,12 @@
+# Case re-export-optimization-for-inaffected-module: Step 0
+
+## Changed Files
+
+
+## Asset Files
+- Bundle: bundle.js
+
+## Manifest
+
+
+## Update

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/__snapshots__/web/1.snap.txt

@@ -0,0 +1,58 @@
+# Case re-export-optimization-for-inaffected-module: Step 1
+
+## Changed Files
+- module.js
+
+## Asset Files
+- Bundle: bundle.js
+- Manifest: main.LAST_HASH.hot-update.json, size: 28
+- Update: main.LAST_HASH.hot-update.js, size: 616
+
+## Manifest
+
+### main.LAST_HASH.hot-update.json
+
+```json
+{"c":["main"],"r":[],"m":[]}
+```
+
+
+## Update
+
+
+### main.LAST_HASH.hot-update.js
+
+#### Changed Modules
+- ./module.js
+
+#### Changed Runtime Modules
+- webpack/runtime/get_full_hash
+
+#### Changed Content
+```js
+"use strict";
+self["webpackHotUpdate"]('main', {
+"./module.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
+__webpack_require__.r(__webpack_exports__);
+__webpack_require__.d(__webpack_exports__, {
+  value: function() { return value; }
+});
+/* harmony import */var _reexports__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./reexports */ "./foo.js");
+
+const value = '' + _reexports__WEBPACK_IMPORTED_MODULE_0__.v;
+
+
+}),
+
+},function(__webpack_require__) {
+// webpack/runtime/get_full_hash
+(() => {
+__webpack_require__.h = function () {
+	return "CURRENT_HASH";
+};
+
+})();
+
+}
+);
+```

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/foo.js

@@ -0,0 +1 @@
+export const v = 'foo'

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/index.js

@@ -0,0 +1,16 @@
+import {value} from "./module";
+
+let v = value;
+module.hot.accept('./module', () => {
+	v = value
+});
+
+it("should auto-reexport an ES6 imported value on accept with newTreeshaking", async function (done) {
+	expect(v).toBe("foo");
+	NEXT(
+		require("../../update")(done, true, () => {
+			expect(v).toBe("foo");
+			done();
+		})
+	);
+});

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/module.js

@@ -0,0 +1,6 @@
+import {v} from './reexports'
+//
+export const value = '' + v;
+---
+import {v} from './reexports'
+export const value = '' + v;

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/package.json

@@ -0,0 +1 @@
+{}

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports-deep.js

@@ -0,0 +1,2 @@
+import {v} from './foo';
+export {v};

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports.js

@@ -0,0 +1 @@
+export { v } from "./reexports-deep";

packages/rspack-test-tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/rspack.config.js

@@ -0,0 +1,12 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	optimization: {
+		sideEffects: true,
+		providedExports: true,
+	},
+	experiments: {
+		rspackFuture: {
+			newIncremental: true
+		}
+	}
+};