-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type error #3863
fix: type error #3863
Conversation
cc @hardfist |
@web-infra-dev/rspack-dx please take a look. |
This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump"). |
bump |
since lots of conflicts here, i will try to fix it in separate PR |
578c1c6
to
78fac29
Compare
This pr merely introduces some type checkers and does not affect the existing logic. Therefore, I think it can be merged once the ci is happy |
8ea40a6
to
3657a81
Compare
@bvanjoi Can you tell me how to fix ci error? |
The failure occurred at |
This issue can be reproduced locally. But I don't know how to fix it. Can you give me some idea about this? |
I suspect that the issue stems from the |
To be more specific, I believe changing the |
it seems hits the nodejs/node#35889 bug again! |
Head branch was pushed to by a user without write access
ad5ed4c
to
c03ca92
Compare
Head branch was pushed to by a user without write access
Summary
There are many type errors in the current code that prevent the tsc check of js from being enabled. This PR uses a lot of
//@ts-expect-error
to bypass type checking errors.Test Plan