Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: takedown node14 test on windows #4068

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Aug 30, 2023

Summary

https://github.com/web-infra-dev/rspack/actions/runs/6021243804/job/16334084913#step:8:367 node14 on windows is broken and we can't fix it now, it seems related to nodejs itself
nodejs/help#2660

Test Plan

@hardfist hardfist requested a review from Boshen as a code owner August 30, 2023 07:53
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 30, 2023
@hardfist hardfist enabled auto-merge August 30, 2023 08:00
@hardfist hardfist disabled auto-merge August 30, 2023 08:10
@hardfist hardfist merged commit 35ba974 into main Aug 30, 2023
@hardfist hardfist deleted the remove-node14-windows branch August 30, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant